Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geist: Version 1.400 added #8246

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Geist: Version 1.400 added #8246

merged 2 commits into from
Oct 24, 2024

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Oct 3, 2024

Taken from the upstream repo https://github.com/vercel/geist-font at commit vercel/geist-font@1bd07b1.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Copy link

github-actions bot commented Oct 3, 2024

FontBakery report

fontbakery version: 0.13.0a1

Check results

[21] Geist[wght].ttf
🔥 FAIL Is this a proper HTML snippet?
  • 🔥 FAIL

    None does not include an HTML

    tag.


    [code: lacks-paragraph]
⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret positioning values for these ligature glyphs:

  • hyphen_greater.liga
  • hyphen_hyphen_greater.liga
  • hyphen_hyphen_hyphen_greater.liga
  • less_hyphen.liga
  • less_hyphen_greater.liga
  • less_hyphen_hyphen.liga
  • less_hyphen_hyphen_hyphen.liga


    [code: incomplete-caret-pos-data]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- hyphen + greater

- hyphen + hyphen

- less + hyphen

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 534 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 558: plus

Width = 540: divide, equal, notequal

Width = 500: logicalnot

Width = 538: plusminus

Width = 502: multiply

Width = 520: minus

Width = 523: approxequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- blackCircled

- uni0306.cy

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    hyphen_hyphen_hyphen_greater.liga and periodcentered.loclCAT.case.ss08


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Andrés Briganti is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Mateo Zaragoza is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Guillermo Rauch is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Evil Rabbit is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that José Rago is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Facundo Santana is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: math, tai-le, tifinagh, duployan, malayalam, coptic, hebrew, todhri, syriac, canadian-aboriginal, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 128 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Navajo (Latn, 166,319 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kom (Latn, 360,685 speakers), Mango (Latn, 77,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Gulay (Latn, 250,478 speakers), Ebira (Latn, 2,200,000 speakers), Mundani (Latn, 34,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ejagham (Latn, 120,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ma’di (Latn, 584,000 speakers), Igbo (Latn, 27,823,640 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Avokaya (Latn, 100,000 speakers), Ekpeye (Latn, 226,000 speakers), Makaa (Latn, 221,000 speakers), Bafut (Latn, 158,146 speakers), Nzakara (Latn, 50,000 speakers), Dan (Latn, 1,099,244 speakers), Sar (Latn, 500,000 speakers), Nateni (Latn, 100,000 speakers), Cicipu (Latn, 44,000 speakers), Dii (Latn, 71,000 speakers), Koonzime (Latn, 40,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Zapotec (Latn, 490,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Yala (Latn, 200,000 speakers), Vute (Latn, 21,000 speakers).

[code: soft-dotted]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'VRCL' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/geist


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "Geist" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/geist/Geist[wght].ttf
Dehinted Size 138.5kb
Hinted Size 138.5kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Cyr


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.400']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-ital', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 12 48 9 183 0
0% 0% 0% 5% 19% 4% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve linked an issue Oct 3, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Oct 3, 2024

FontBakery report

fontbakery version: 0.13.0a1

Check results

[20] Geist[wght].ttf
⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret positioning values for these ligature glyphs:

  • hyphen_greater.liga
  • hyphen_hyphen_greater.liga
  • hyphen_hyphen_hyphen_greater.liga
  • less_hyphen.liga
  • less_hyphen_greater.liga
  • less_hyphen_hyphen.liga
  • less_hyphen_hyphen_hyphen.liga


    [code: incomplete-caret-pos-data]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- hyphen + greater

- hyphen + hyphen

- less + hyphen

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 534 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 558: plus

Width = 540: equal, divide, notequal

Width = 500: logicalnot

Width = 538: plusminus

Width = 502: multiply

Width = 520: minus

Width = 523: approxequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- blackCircled

- uni0306.cy

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    hyphen_hyphen_hyphen_greater.liga and periodcentered.loclCAT.case.ss08


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Andrés Briganti is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Mateo Zaragoza is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Guillermo Rauch is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Evil Rabbit is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that José Rago is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Facundo Santana is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, tifinagh, cherokee
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, old-permic, hebrew, math, canadian-aboriginal, tai-le, tifinagh, todhri, coptic, syriac, duployan
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 128 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Belarusian (Cyrl, 10,064,517 speakers), Lithuanian (Latn, 2,357,094 speakers), Navajo (Latn, 166,319 speakers), Ukrainian (Cyrl, 29,273,587 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Ejagham (Latn, 120,000 speakers), Makaa (Latn, 221,000 speakers), Ekpeye (Latn, 226,000 speakers), Dan (Latn, 1,099,244 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Vute (Latn, 21,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Mundani (Latn, 34,000 speakers), Lugbara (Latn, 2,200,000 speakers), Gulay (Latn, 250,478 speakers), Koonzime (Latn, 40,000 speakers), Cicipu (Latn, 44,000 speakers), Southern Kisi (Latn, 360,000 speakers), Basaa (Latn, 332,940 speakers), Dii (Latn, 71,000 speakers), Ma’di (Latn, 584,000 speakers), Bafut (Latn, 158,146 speakers), Bete-Bendi (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Avokaya (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mango (Latn, 77,000 speakers), Kom (Latn, 360,685 speakers), Nateni (Latn, 100,000 speakers), Yala (Latn, 200,000 speakers), Sar (Latn, 500,000 speakers).

[code: soft-dotted]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'VRCL' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/geist


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "Geist" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/geist/Geist[wght].ttf
Dehinted Size 138.5kb
Hinted Size 138.5kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Cyr


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.400']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-ital', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 12 48 9 184 0
0% 0% 0% 5% 19% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

Hi @vv-monsalve:
I found almost the same issues than in the mono version! Here are some precisions:

Interpolation

  • It's weird that the Behdad's tool didn't detect it:
Screenshot 2024-10-04 at 17 49 11

Anchors

  • Same as Mono, with no top anchors on accents:
Screenshot 2024-10-04 at 18 12 05

Cyrillic

  • I compared with some other GF fonts, and the placement seems to be wrong indeed:
Screenshot 2024-10-04 at 17 57 42 Screenshot 2024-10-04 at 17 58 14
  • The issue we had in the mono isn't here, so I would follow this example, with the bars alignement:
Screenshot 2024-10-04 at 17 56 23

Licence url
We need to add back the check about the new URL. Here the licence field isn't in the source info, and the url is wrong.
Screenshot 2024-10-04 at 15 48 13

Small adjustments

  • (same as Mono) Alignements could be improved a bit (but I'm ok to merge it like this)
Screenshot 2024-10-04 at 15 30 33

Kerning

  • The cyrillic kerning could be improved:
Screenshot 2024-10-04 at 18 07 38 Screenshot 2024-10-04 at 18 08 16 Screenshot 2024-10-04 at 18 08 22 Screenshot 2024-10-04 at 18 09 02

@vv-monsalve
Copy link
Collaborator Author

@emmamarichal, Some of the reported kerning in Cyrillic, are working ok in the font.
I've reported this as a suggestion. However, this is a submitted font for which Latin Core is the base support requirement. This should not be considered a blocker.
Screenshot 2024-10-04 at 16 32 54

@m4rc1e m4rc1e added P3 and removed P3 labels Oct 14, 2024
@vv-monsalve
Copy link
Collaborator Author

Updated

@vv-monsalve vv-monsalve added II Accepted Non-commissioned projects that are accepted for onboarding and removed II Accepted Non-commissioned projects that are accepted for onboarding labels Oct 22, 2024

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.13.0a2

Check results

[22] Geist[wght].ttf
🔥 FAIL Check there are no overlapping path segments
  • 🔥 FAIL

    The following glyphs have overlapping path segments:

* uni0416 (U+0416): L<<616.0,355.0>--<500.0,355.0>> has the same coordinates as a previous segment.

* uni0416 (U+0416): L<<428.0,355.0>--<311.0,355.0>> has the same coordinates as a previous segment.

* uni041A (U+041A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni040C (U+040C): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<616.0,355.0>--<500.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<428.0,355.0>--<311.0,355.0>> has the same coordinates as a previous segment.

* uni049A (U+049A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<578.0,265.0>--<467.0,265.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<395.0,265.0>--<282.0,265.0>> has the same coordinates as a previous segment.

* uni043A (U+043A): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

* 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • 🔥 FAIL

    Designer Guillermo Rauch still does not have an avatar image. Please provide one.


    [code: missing-avatar]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]
⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret positioning values for these ligature glyphs:

  • hyphen_greater.liga
  • hyphen_hyphen_greater.liga
  • hyphen_hyphen_hyphen_greater.liga
  • less_hyphen.liga
  • less_hyphen_greater.liga
  • less_hyphen_hyphen.liga
  • less_hyphen_hyphen_hyphen.liga


    [code: incomplete-caret-pos-data]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- hyphen + greater

- hyphen + hyphen

- less + hyphen

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 544 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 558: plus

Width = 540: equal, notequal, divide

Width = 500: logicalnot

Width = 538: plusminus

Width = 502: multiply

Width = 520: minus

Width = 523: approxequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- blackCircled

- uni0306.cy

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    hyphen_hyphen_hyphen_greater.liga and periodcentered.loclCAT.case.ss08


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, duployan, math, old-permic, syriac, tai-le, hebrew, canadian-aboriginal, tifinagh, todhri, coptic
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 128 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Kaska (Latn, 125 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dutch (Latn, 31,709,104 speakers), Han (Latn, 6 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Lugbara (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Cicipu (Latn, 44,000 speakers), Ejagham (Latn, 120,000 speakers), Mundani (Latn, 34,000 speakers), Kom (Latn, 360,685 speakers), Nzakara (Latn, 50,000 speakers), Vute (Latn, 21,000 speakers), Heiltsuk (Latn, 300 speakers), Teke-Ebo (Latn, 260,000 speakers), Bafut (Latn, 158,146 speakers), Makaa (Latn, 221,000 speakers), Ebira (Latn, 2,200,000 speakers), Koonzime (Latn, 40,000 speakers), Avokaya (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Basaa (Latn, 332,940 speakers), Igbo (Latn, 27,823,640 speakers), Mango (Latn, 77,000 speakers), Ekpeye (Latn, 226,000 speakers), Dan (Latn, 1,099,244 speakers), Zapotec (Latn, 490,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Dii (Latn, 71,000 speakers), Nateni (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Mfumte (Latn, 79,000 speakers), Gulay (Latn, 250,478 speakers), Yala (Latn, 200,000 speakers), Fur (Latn, 1,230,163 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Ma’di (Latn, 584,000 speakers).

[code: soft-dotted]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'VRCL' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/geist


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "Geist" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/geist/Geist[wght].ttf
Dehinted Size 146.4kb
Hinted Size 146.5kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Cyr


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.401']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-ital', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 12 48 9 183 0
0% 0% 1% 5% 19% 4% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Oct 23, 2024

@emmamarichal Update for the update:

  • 🔥 FAIL Check there are no overlapping path segments
    Reported to upstream. We'll need to wait for them to make the changes >.<
  • 🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
    The designer didn't want to include an image. I would not consider this as a blocker.

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 23, 2024
@vv-monsalve
Copy link
Collaborator Author

Updated

@vv-monsalve vv-monsalve added the II Accepted Non-commissioned projects that are accepted for onboarding label Oct 23, 2024

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.13.0a2

Check results

[22] Geist[wght].ttf
🔥 FAIL Check there are no overlapping path segments
  • 🔥 FAIL

    The following glyphs have overlapping path segments:

* uni041A (U+041A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni040C (U+040C): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni049A (U+049A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<578.0,265.0>--<467.0,265.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<395.0,265.0>--<282.0,265.0>> has the same coordinates as a previous segment.

* uni043A (U+043A): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

* uni045C (U+045C): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<578.0,265.0>--<467.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<395.0,265.0>--<282.0,265.0>> has the same coordinates as a previous segment.

* uni049B (U+049B): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • 🔥 FAIL

    Designer Guillermo Rauch still does not have an avatar image. Please provide one.


    [code: missing-avatar]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]
⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret positioning values for these ligature glyphs:

  • hyphen_greater.liga
  • hyphen_hyphen_greater.liga
  • hyphen_hyphen_hyphen_greater.liga
  • less_hyphen.liga
  • less_hyphen_greater.liga
  • less_hyphen_hyphen.liga
  • less_hyphen_hyphen_hyphen.liga


    [code: incomplete-caret-pos-data]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- hyphen + greater

- hyphen + hyphen

- less + hyphen

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 544 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 558: plus

Width = 540: equal, divide, notequal

Width = 500: logicalnot

Width = 538: plusminus

Width = 502: multiply

Width = 520: minus

Width = 523: approxequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- blackCircled

- uni0306.cy

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    hyphen_hyphen_hyphen_greater.liga and periodcentered.loclCAT.case.ss08


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, coptic, cherokee
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, duployan, malayalam, hebrew, tai-le, canadian-aboriginal, tifinagh, math, todhri, syriac, coptic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 128 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Han (Latn, 6 speakers), Kaska (Latn, 125 speakers), Navajo (Latn, 166,319 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Mundani (Latn, 34,000 speakers), Yala (Latn, 200,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Makaa (Latn, 221,000 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), Ebira (Latn, 2,200,000 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Kom (Latn, 360,685 speakers), Zapotec (Latn, 490,000 speakers), Dan (Latn, 1,099,244 speakers), Ma’di (Latn, 584,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), South Central Banda (Latn, 244,000 speakers), Nateni (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Heiltsuk (Latn, 300 speakers), Bafut (Latn, 158,146 speakers), Gulay (Latn, 250,478 speakers), Ekpeye (Latn, 226,000 speakers), Basaa (Latn, 332,940 speakers), Igbo (Latn, 27,823,640 speakers), Fur (Latn, 1,230,163 speakers), Cicipu (Latn, 44,000 speakers), Sar (Latn, 500,000 speakers), Vute (Latn, 21,000 speakers), Mfumte (Latn, 79,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mango (Latn, 77,000 speakers), Ngbaka (Latn, 1,020,000 speakers).

[code: soft-dotted]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'VRCL' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/geist


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "Geist" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/geist/Geist[wght].ttf
Dehinted Size 146.4kb
Hinted Size 146.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Cyr


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.401']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-ital', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 12 48 9 183 0
0% 0% 1% 5% 19% 4% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

@emmamarichal

  • 🔥 FAIL Check there are no overlapping path segments

    The design team worked on the previously reported cases, but some new ones emerged. I tested the concerned glyphs on Chrome and Indesign, and there were no rendering issues. Also, Marc said about this check, "I think this check may already be redundant since Chrome 130 has fixed it." So I would not consider this a blocker.

@vv-monsalve vv-monsalve removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 23, 2024
@emmamarichal
Copy link
Collaborator

Lgtm!

I still see some small issues in cyr, but I'll not consider them as blockers, if we want to focus on latin fom now.
I just report them here, we can open an issue on the repo for the next update!

I'll wait for your answer before merging it!

Cyrillique

  • uni0409: this thicker stem was not here in the previous version
Screenshot 2024-10-24 at 10 08 43
  • very small connexion issue with the components:
Screenshot 2024-10-24 at 10 09 41 Screenshot 2024-10-24 at 10 10 12
  • alignement issue:
Screenshot 2024-10-24 at 10 09 55

@emmamarichal emmamarichal merged commit c0b7dce into main Oct 24, 2024
8 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_geist branch October 24, 2024 13:27
@vv-monsalve
Copy link
Collaborator Author

I'll wait for your answer before merging it!

After the initial Cyrillic comments, designers said: " the cyrillic was not reviewed and requires a complete overhaul".

So, the best option for a clean release would be to delist the Cyrillic subset. I'll do it in a quick follow-up PR today.
I'll also add the above comments to the upstream issue where this was discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding P3
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Geist & Geist Mono
3 participants